[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bergmannf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

looks pretty good to me
if you want you could separate the refactors and the mcp into two PRs :)

@bergmannf: all tests passed!

Full PR test history. Your PR dashboard.

looks pretty good to me if you want you could separate the refactors and the mcp into two PRs :)

I felt that the changes I made would be way uglier if I didn't refactor as well, as all our commands make everything private and make it unnecessarily hard to call them from elsewhere.

If you feel strongly about it I can split the PR though.

looks pretty good to me if you want you could separate the refactors and the mcp into two PRs :)

I felt that the changes I made would be way uglier if I didn't refactor as well, as all our commands make everything private and make it unnecessarily hard to call them from elsewhere.

If you feel strongly about it I can split the PR though.

I have always wanted to slowly push our cmd/ packages to be thin and move all the business logic into pkg/cluster/context (for example) type packages. Then the CLI is a small shim over calling actual exported code that could be consumed by other projects, vs them calling our CLI functions.

Do with that what you will, by no means saying you have to, but figured I'd mention it.

looks pretty good to me if you want you could separate the refactors and the mcp into two PRs :)

I felt that the changes I made would be way uglier if I didn't refactor as well, as all our commands make everything private and make it unnecessarily hard to call them from elsewhere.
If you feel strongly about it I can split the PR though.

I have always wanted to slowly push our cmd/ packages to be thin and move all the business logic into pkg/cluster/context (for example) type packages. Then the CLI is a small shim over calling actual exported code that could be consumed by other projects, vs them calling our CLI functions.

Do with that what you will, by no means saying you have to, but figured I'd mention it.

Absolutely - essentially I'd like the CLI to really be the thinnest layer of input - essentially right now we have all the logic in the view layer of MVC and the goal should be moving to the C layer (which we don't have).
This was really just a quick refactor to make it less ugly to expose it for now.

/hold
I am holding this for now as there are guidelines form the ProdSec team coming along we want to make sure we adhere with before merging and releasing this.

PR needs rebase.

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale